[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1422991741 Thanks @hachikuji! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1421105810 @hachikuji Thanks for your review. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1418729277 @hachikuji Thanks for your comments. I have addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1384315580 @hachikuji I played a bit with your suggesting and I personally prefer the current approach: `"apiStability": "evolving|stable"`. It is a bit odd to specify the unstable version because it is always the last one. Instead, I think that we could involve the current approach to apply `apiStability` to the last version only. I would save this for another patch because it is not strictly required for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1377643457 Yeah, that's an interesting though. That's true that the `apiStability` in the spec only works for new APIs. Let me check and see how feasible that is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1377592620 @hachikuji What do you think about the _internal_ config name `unreleased.apis.enable` (boolean)? An alternative with your suggestion would be to have something like `apis.enabled` taking a list of "api stability type" to be exposed or just taking `stable` or `evolving` where `evolving` implies that `stable` apis are included as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1377449336 > Would it be possible to make the release status part of the JSON spec? For example: > > ```json > "apiStability": "evolving|stable" > ``` That's a good idea. Let me do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API
dajac commented on PR #12972: URL: https://github.com/apache/kafka/pull/12972#issuecomment-1344397829 This PR incudes https://github.com/apache/kafka/pull/12969 for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
