[GitHub] [kafka] dajac commented on pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-16 Thread via GitHub 


dajac commented on PR #13323:
URL: https://github.com/apache/kafka/pull/13323#issuecomment-1471913482

   Failed tests are not related to this PR:
   ```
   [Build / JDK 17 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1] 
Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, 
Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_17_and_Scala_2_131__Type_ZK__Name_testDualWrite__MetadataVersion_3_4_IV0__Security_PLAINTEXT/)
   [Build / JDK 17 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1] 
Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, 
Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_17_and_Scala_2_131__Type_ZK__Name_testDualWrite__MetadataVersion_3_4_IV0__Security_PLAINTEXT_2/)
   [Build / JDK 11 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1] 
Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, 
Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_11_and_Scala_2_131__Type_ZK__Name_testDualWrite__MetadataVersion_3_4_IV0__Security_PLAINTEXT/)
   [Build / JDK 11 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1] 
Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, 
Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_11_and_Scala_2_131__Type_ZK__Name_testDualWrite__MetadataVersion_3_4_IV0__Security_PLAINTEXT_2/)
   [Build / JDK 8 and Scala 2.12 / kafka.admin.LeaderElectionCommandTest.[3] 
Type=ZK, Name=testPathToJsonFile, MetadataVersion=3.5-IV1, 
Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.admin/LeaderElectionCommandTest/Build___JDK_8_and_Scala_2_123__Type_ZK__Name_testPathToJsonFile__MetadataVersion_3_5_IV1__Security_PLAINTEXT/)
   [Build / JDK 8 and Scala 2.12 / 
kafka.admin.TopicCommandIntegrationTest.testTopicDeletion(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.admin/TopicCommandIntegrationTest/Build___JDK_8_and_Scala_2_12___testTopicDeletion_String__quorum_kraft/)
   [Build / JDK 8 and Scala 2.12 / 
kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.server/DynamicBrokerReconfigurationTest/Build___JDK_8_and_Scala_2_12___testTrustStoreAlter_String__quorum_kraft/)
   [Build / JDK 8 and Scala 2.12 / kafka.zk.ZkMigrationIntegrationTest.[1] 
Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, 
Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_8_and_Scala_2_121__Type_ZK__Name_testDualWrite__MetadataVersion_3_4_IV0__Security_PLAINTEXT/)
   [Build / JDK 8 and Scala 2.12 / kafka.zk.ZkMigrationIntegrationTest.[1] 
Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, 
Security=PLAINTEXT](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-13323/16/testReport/junit/kafka.zk/ZkMigrationIntegrationTest/Build___JDK_8_and_Scala_2_121__Type_ZK__Name_testDualWrite__MetadataVersion_3_4_IV0__Security_PLAINTEXT_2/)
   ```
   
   I am going to merge it to trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-15 Thread via GitHub 


dajac commented on PR #13323:
URL: https://github.com/apache/kafka/pull/13323#issuecomment-1470710416

   @CalvinConfluent Could you rebase as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

2023-03-09 Thread via GitHub 


dajac commented on PR #13323:
URL: https://github.com/apache/kafka/pull/13323#issuecomment-1462452965

   @CalvinConfluent Could you rebase the PR? There are a few conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #13323: KAFKA-14617; Add ReplicaState to FetchRequest.

2023-03-02 Thread via GitHub 


dajac commented on PR #13323:
URL: https://github.com/apache/kafka/pull/13323#issuecomment-1452269739

   @CalvinConfluent Thanks for the explanation. I agree that we have two 
options on the table: 1) pass the api version or even the header object; or 2) 
rely on the default sentinel value to read the correct field. Personally, I 
lean towards 2) here because it is simpler. It would be great to run this by 
@hachikuji as the authored this part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org