[GitHub] [kafka] dajac commented on pull request #14271: KAFKA-14503: Implement ListGroups
dajac commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1717271418 @zhaohaidao Thanks for all the work you are doing on this. I really appreciate it. I have created a few jiras for the next steps: * https://issues.apache.org/jira/browse/KAFKA-15460 * https://issues.apache.org/jira/browse/KAFKA-15461 * https://issues.apache.org/jira/browse/KAFKA-15462 I have assigned all of them to you for now as you were interested in pursuing this work. Feel free to unassign them if you don't want or plan to tackle them. From a priority perspective, tacking https://issues.apache.org/jira/browse/KAFKA-14504 before the above mentioned jiras would be really helpful as it will allow us to start end-to-end testing when we have all the existing APIs in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #14271: KAFKA-14503: Implement ListGroups
dajac commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1715178703 Hey @zhaohaidao. Would you have an idea when you will be able to address the remaining comments? I would like to merge this one as soon as possible. We need KAFKA-14503 and KAFKA-14504 for end-to-end testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #14271: KAFKA-14503: Implement ListGroups
dajac commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1713782755 @zhaohaidao I just realized that we don't have any integration tests for this API. It would be great to add a few like I did [here](https://github.com/apache/kafka/pull/14353) for other APIs. Would you be interested by doing this? It could be done in a separate PR for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #14271: KAFKA-14503: Implement ListGroups
dajac commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1707768637 @zhaohaidao There is a bunch of conflicts with `trunk`. Could you please fix them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #14271: KAFKA-14503: Implement ListGroups
dajac commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1701313706 @zhaohaidao Those are mainly flaky tests. There is one comment which is not addressed. Could you look into it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #14271: KAFKA-14503: Implement ListGroups
dajac commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1689042864 > @dajac hi, could you pls help me see the check error log. I don't quite understand the root cause and what should be fixed myself. The check error log is as followed > > > coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:129:1: Class Data Abstraction Coupling is 26 (max allowed is 25) classes [CompletableFuture, ConsumerGroup, ConsumerGroupHeartbeatResponseData, ConsumerGroupHeartbeatResponseData.Assignment, ConsumerGroupHeartbeatResponseData.TopicPartitions, ConsumerGroupMember.Builder, CoordinatorResult, CurrentAssignmentBuilder, FencedMemberEpochException, GenericGroup, GenericGroupMember, GroupIdNotFoundException, GroupMaxSizeReachedException, HeartbeatResponseData, InvalidRequestException, JoinGroupRequestProtocol, JoinGroupRequestProtocolCollection, JoinGroupResponseData, ListGroupsResponseData, SyncGroupResponseData, TargetAssignmentBuilder, TimelineHashMap, TimelineHashSet, UnknownMemberIdException, UnknownServerException, UnsupportedAssignorException]. @zhaohaidao It looks like we have hit the maximum number of imports. We could consider adding an exception for this. Have you tried this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
