[GitHub] [kafka] dajac commented on pull request #9878: KAFKA-6987: Reimplement KafkaFuture using CompletableFuture
dajac commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-764677084 @ijuma I was actually thinking about the same. The new or the old could likely be a thin facade of the other. Another approach would be to duplicate all the methods in the *Result classes but that does not sound good to me. I think that it would be nice if we could eventually remove `KafkaFuture` and use `CompletionStage` instead. That would be nice from a user of the admin api perspective at least. That would also be inline with the producer api KIP-706 lands in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9878: KAFKA-6987: Reimplement KafkaFuture using CompletableFuture
dajac commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-764677084 @ijuma I was actually thinking about the same. The new or the old could likely be a thin facade of the other. Another approach would be to duplicate all the methods in the *Result classes but that does not sound good to me. I think that it would be nice if we could eventually remove `KafkaFuture` and use `CompletionStage` instead. That would be nice from a user of the admin api perspective at least. That would also be inline with the producer api KIP-706 lands in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #9878: KAFKA-6987: Reimplement KafkaFuture using CompletableFuture
dajac commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-762933747 @tombentley Thanks for the PR. I wonder if `KafkaFuture` could implement `CompletionStage` and thus could be directly used with Java Future. Did we consider this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
