[GitHub] [kafka] dejan2609 edited a comment on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)
dejan2609 edited a comment on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-821968689
> Could we reintroduce a configuration that behaves the same as
`testRuntime` did before it was removed?
@ijuma Can you please expand on this ? Are you referring to a `testRuntime`
mentioned in a `copyDependantLibs` task ?
https://github.com/apache/kafka/blob/2.8.0-rc2/build.gradle#L1472
```
project(':streams') {
...
tasks.create(name: "copyDependantLibs", type: Copy) {
from (configurations.testRuntime) {
...
}
...
}
```
~Or we now just brainstorm about Gradle behavior _**in-general**_ ?~
Thing is that this code was introduced back in the year 2015. (as a
fresh/newly added code).
Also `testRuntime` configuration was added to an initial Gradle version:
https://docs.gradle.org/1.0/userguide/artifact_dependencies_tutorial.html#configurations
I see that `tasks.create(name: "copyDependantLibs", type: Copy)` logic is
applied to a dozen of submodules (15 in total, to be more precise). I didn't
check, but it is safe to say that this is an prerequisite for `releaseTarGz`
tasks (i.e. full distribution tasks).
I will try to compare other 14 (that work as expected) with this one (that
fails).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dejan2609 edited a comment on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)
dejan2609 edited a comment on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-821837798
Digging through project history I managed to find some commits that are
seems to be related (see the comment):
```
project(':streams') {
dependencies {
api project(':clients')
// testCompileOnly prevents streams from exporting a dependency on
test-utils, which would cause a dependency cycle
testCompileOnly project(':streams:test-utils')
testRuntimeOnly project(':streams:test-utils')
}
}
```
@vvcephei contributed two PRs (#4821 and #4812) 3 years ago and these are
related commits:
- **05. Apr 2018**.
https://github.com/apache/kafka/commit/d5db4e9b8055536bdbb3b2d2308e36efa4abafcc
- **23. Apr 2018.**
https://github.com/apache/kafka/commit/ed51b2cdf5bdac210a6904bead1a2ca6e8411406
Out of curiosity I tried to consolidate these dependency into one
`testImplementation project(':streams:test-utils')` and here are the results:
- on top of trunk: build works fine ✔️
- on top of this PR: build fails ❌ (with identical `Circular dependency
between the following tasks` error as above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] dejan2609 edited a comment on pull request #10466: KAFKA-12417 "streams" module: switch deprecated Gradle configuration (`testRuntime` -->> `testRuntimeClasspath`)
dejan2609 edited a comment on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-821837798
Digging through project history I managed to find some commits that are
seems to be related (see the comment):
```
project(':streams') {
dependencies {
api project(':clients')
// testCompileOnly prevents streams from exporting a dependency on
test-utils, which would cause a dependency cycle
testCompileOnly project(':streams:test-utils')
testRuntimeOnly project(':streams:test-utils')
}
}
```
@vvcephei contributed two PRs (#4821 and #4812) 3 years ago and these are
related commits:
- **05. Apr 2018**.
https://github.com/apache/kafka/commit/d5db4e9b8055536bdbb3b2d2308e36efa4abafcc
- **23. Apr 2018.**
https://github.com/apache/kafka/commit/ed51b2cdf5bdac210a6904bead1a2ca6e8411406
Out of curiosity I tried to consolidate these dependency into one
`testImplementation project(':streams:test-utils')` and here are the results:
- on top of trunk: build works fine ✔️
- on top of this PR: build fails ❌ (with identical `Circular dependency
between the following tasks` error as above)
(...moving to phase 3...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
