[GitHub] [kafka] dejan2609 edited a comment on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-06-04 Thread GitBox


dejan2609 edited a comment on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] dejan2609 edited a comment on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-06-02 Thread GitBox


dejan2609 edited a comment on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053


   Just tagging @ijuma here again (to bring back this PR up to the surface).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] dejan2609 edited a comment on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-06-02 Thread GitBox


dejan2609 edited a comment on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053


   Just tagging @ijuma here again (to put back this PR up to the surface).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] dejan2609 edited a comment on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-05-24 Thread GitBox


dejan2609 edited a comment on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-847174293


   If I may ask you @showuon: do we need to ping someone else for another 
review (or for merge into trunk) ? 
   
   _Edit (just to answer to my self): there are two types of approvals and 
hence this PR does need an additional review(s)... in any case: thanx @showuon 
!_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org