[GitHub] [kafka] dengziming commented on a change in pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

2021-02-23 Thread GitBox 


dengziming commented on a change in pull request #10135:
URL: https://github.com/apache/kafka/pull/10135#discussion_r580879641



##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -134,6 +134,8 @@ class KafkaServer(
 
   var autoTopicCreationManager: AutoTopicCreationManager = null
 
+  var clientToControllerChannelManager: 
Option[BrokerToControllerChannelManager] = None
+
   var alterIsrManager: AlterIsrManager = null

Review comment:
   Looks good, I will try to file a ticket to consolidate broker to 
controller channel. 😉
   It seems that the `BrokerServer` also holds AutoTopicCreationManager and 
ForwardingManager, so it also need to be changed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] dengziming commented on a change in pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

2021-02-16 Thread GitBox 


dengziming commented on a change in pull request #10135:
URL: https://github.com/apache/kafka/pull/10135#discussion_r577312082



##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -134,6 +134,8 @@ class KafkaServer(
 
   var autoTopicCreationManager: AutoTopicCreationManager = null
 
+  var clientToControllerChannelManager: 
Option[BrokerToControllerChannelManager] = None
+
   var alterIsrManager: AlterIsrManager = null

Review comment:
   Hello, I have a question, should we also share the channel between 
alterIsrManager and autoCreationManager, furthermore, also share the same one 
with alterReplicaStateManager proposed in KIP-589.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org