[GitHub] [kafka] dengziming commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse
dengziming commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1562174228 @KarboniteKream I reproduced this in #13761 , you can run the new test case and help investigating if you are interested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse
dengziming commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1560714746 @KarboniteKream Thank you for reporting this, I'm trying to reproduce your case locally but failed, do you mean that this problem only occur after the leader is shut down and restarted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse
dengziming commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1545197689 The failed tests are flaky and also failed recently in other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse
dengziming commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1543964126 I rerun the failed tests locally and they work correctly, I create a JIRA to track this problem. https://issues.apache.org/jira/browse/KAFKA-14989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse
dengziming commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1541425575 @showuon There are a lot of errors, I find that `ApiVersionRequest` is very important, when all nodes start, the `NetworkClient` will be initialized and `ApiVersionRequest` will be sent to learn the api version information of other nodes. It is possible that at this time, the controller has not yet started consuming the log, and we should return an empty value, I made a minor change to `QuorumController#finalizedFeatures`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
