divijvaidya commented on code in PR #12112: URL: https://github.com/apache/kafka/pull/12112#discussion_r862714992
########## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ########## @@ -586,11 +586,14 @@ class TopicCommandIntegrationTest extends KafkaServerTestHarness with Logging wi try { killBroker(0) val aliveServers = brokers.filterNot(_.config.brokerId == 0) - TestUtils.waitForPartitionMetadata(aliveServers, testTopicName, 0) + TestUtils.waitUntilTrue( Review Comment: Can we alternatively use one of the existing methods in TestUtils to validate that the topic partition ISR contains rest of the 5 brokers e.g. using `TestUtils.waitForBrokersInIsr` could validate that the topic partition metadata exists in expected number of Isr even after one of the brokers is terminated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org