divijvaidya commented on code in PR #12381:
URL: https://github.com/apache/kafka/pull/12381#discussion_r914730050
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -429,6 +430,20 @@ class DynamicBrokerReconfigurationTest extends
QuorumTestHarness with SaslSetup
verifyProduceConsume(producer, consumer, 10, topic)
}
+ def verifyBrokerToControllerCall(controller: KafkaServer): Unit = {
+ val nonControllerBroker = servers.find(_.config.brokerId !=
controller.config.brokerId).get
+ val brokerToControllerManager =
nonControllerBroker.clientToControllerChannelManager
+ val completionHandler = new TestControllerRequestCompletionHandler()
+ brokerToControllerManager.sendRequest(new MetadataRequest.Builder(new
MetadataRequestData()), completionHandler)
+ TestUtils.waitUntilTrue(() => {
+ completionHandler.completed.get() || completionHandler.timedOut.get()
+ }, "Timed out while waiting for broker to controller API call")
+ val response = completionHandler.actualResponse.getOrElse(throw new
IllegalStateException("No response recorded even though request is completed"))
Review Comment:
Both your comments make sense. I have make the changes as per your
suggestions.
##########
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##########
@@ -189,6 +188,10 @@ class BrokerToControllerChannelManagerImpl(
config.saslInterBrokerHandshakeRequestEnable,
logContext
)
+ channelBuilder match {
+ case reconfigurable: Reconfigurable =>
config.addReconfigurable(reconfigurable)
+ case _ =>
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
