[GitHub] [kafka] divijvaidya commented on a diff in pull request #13673: MINOR: Update dependencies (minor versions only)
divijvaidya commented on code in PR #13673: URL: https://github.com/apache/kafka/pull/13673#discussion_r1185999578 ## gradle/dependencies.gradle: ## @@ -142,7 +142,7 @@ libs += [ apachedsMavibotPartition: "org.apache.directory.server:apacheds-mavibot-partition:$versions.apacheds", apachedsJdbmPartition: "org.apache.directory.server:apacheds-jdbm-partition:$versions.apacheds", argparse4j: "net.sourceforge.argparse4j:argparse4j:$versions.argparse4j", - bcpkix: "org.bouncycastle:bcpkix-jdk15on:$versions.bcpkix", + bcpkix: "org.bouncycastle:bcpkix-jdk18on:$versions.bcpkix", Review Comment: FYI, reviewers, this changes the version of bouncycaste which is compatible from JDK 1.8 onwards instead of earlier JDK 1.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #13673: MINOR: Update dependencies (minor versions only)
divijvaidya commented on code in PR #13673: URL: https://github.com/apache/kafka/pull/13673#discussion_r1185999578 ## gradle/dependencies.gradle: ## @@ -142,7 +142,7 @@ libs += [ apachedsMavibotPartition: "org.apache.directory.server:apacheds-mavibot-partition:$versions.apacheds", apachedsJdbmPartition: "org.apache.directory.server:apacheds-jdbm-partition:$versions.apacheds", argparse4j: "net.sourceforge.argparse4j:argparse4j:$versions.argparse4j", - bcpkix: "org.bouncycastle:bcpkix-jdk15on:$versions.bcpkix", + bcpkix: "org.bouncycastle:bcpkix-jdk18on:$versions.bcpkix", Review Comment: This changes the version of bouncycaste which is compatible from JDK 1.8 onwards instead of earlier JDK 1.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
