[GitHub] [kafka] dongjinleekr commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

[GitBox]

dongjinleekr commented on a change in pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#discussion_r525845117



##
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##
@@ -186,19 +186,29 @@ public void shouldReportDirectoryEmpty() throws 
IOException {
 
 @Test
 public void shouldThrowProcessorStateException() throws IOException {

Review comment:
   Totally agree. :smile: 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

[GitBox]

dongjinleekr commented on a change in pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#discussion_r525835354



##
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java
##
@@ -140,9 +140,6 @@ public void 
shouldWorkWithUncleanShutdownWipeOutStateStore() throws InterruptedE
 IntegrationTestUtils.produceSynchronously(producerConfig, false, 
input, Optional.empty(),
 singletonList(new KeyValueTimestamp<>("k1", "v1", 0L)));
 
-TestUtils.waitForCondition(stateDir::exists,
-"Failed awaiting CreateTopics first request failure");

Review comment:
   - Previous: The test asserts that the (empty) StateStore directory is 
not deleted.
   - Now: The empty StateStore directory is deleted in the cleanup process, so 
this assertion is no longer valid. (wait, would it much better to negate the 
logical condition instead of removing it?)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org