[GitHub] [kafka] eziosudo commented on pull request #13982: KAFKA-15159: upgrade minor dependencies

2023-07-10 Thread via GitHub 


eziosudo commented on PR #13982:
URL: https://github.com/apache/kafka/pull/13982#issuecomment-1630095390

   > scalaCollectionCompat has a new version `2.11`, did we consider that?
   
   Yes, just found the release note here, seems harmless. 
   https://github.com/scala/scala-collection-compat/releases/tag/v2.11.0
   
   By the way, scalaLogging also has a new version '3.9.5', but the release 
notes didn't update, Do you think we can upgrade it as well ? 
   https://github.com/lightbend-labs/scala-logging/releases
   https://mvnrepository.com/artifact/com.typesafe.scala-logging/scala-logging
   https://github.com/apache/kafka/assets/54128896/c6623dd2-ac33-477c-b203-522295f05213";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] eziosudo commented on pull request #13982: KAFKA-15159: upgrade minor dependencies

2023-07-10 Thread via GitHub 


eziosudo commented on PR #13982:
URL: https://github.com/apache/kafka/pull/13982#issuecomment-1629456542

   > Thank you for the changes. We need to update the corresponding entries in 
LICENSE file too:
   > 
   > 
https://github.com/apache/kafka/blob/d481163d55a1cea3206fa6e386b24ac84e17c3d7/LICENSE-binary#L244
   
   Thanks for the review. Already update LICENSE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org