[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-867277063 @bbejeck Failed test also appear in other issues. I think it's unrelated. ``` org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions() ``` Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-867105129 @bbejeck Thanks for the review. You are right Please help me review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…
g1geordie commented on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-815594893
@bbejeck
Thanks for your response !!
I see the compatibility claim in NamedInternal.
```
String orElseGenerateWithPrefix(final InternalNameProvider provider, final
String prefix) {
// We actually do not need to generate processor names for operation
if a name is specified.
// But before returning, we still need to burn index for the
operation to keep topology backward compatibility.
...
}
```
The index is not correct in
SuppressTopologyTest.shouldApplyNameToSuppressionNode.
```
without `.suppress(... .withName("asdf"))` name option.
Topologies:
Sub-topology: 0
Source: KSTREAM-SOURCE-00 (topics: [input])
--> KSTREAM-AGGREGATE-02
Processor: KSTREAM-AGGREGATE-02 (stores:
[KSTREAM-AGGREGATE-STATE-STORE-01])
--> KTABLE-SUPPRESS-03
<-- KSTREAM-SOURCE-00
Processor: KTABLE-SUPPRESS-03 (stores:
[KTABLE-SUPPRESS-STATE-STORE-04])
--> KTABLE-TOSTREAM-05
<-- KSTREAM-AGGREGATE-02
Processor: KTABLE-TOSTREAM-05 (stores: [])
--> KSTREAM-SINK-06
<-- KTABLE-SUPPRESS-03
Sink: KSTREAM-SINK-06 (topic: output)
<-- KTABLE-TOSTREAM-05
```
So I change expected index to below .
```
Topologies:
Sub-topology: 0
Source: KSTREAM-SOURCE-00 (topics: [input])
--> KSTREAM-AGGREGATE-02
Processor: KSTREAM-AGGREGATE-02 (stores:
[KSTREAM-AGGREGATE-STATE-STORE-01])
--> asdf
<-- KSTREAM-SOURCE-00
Processor: asdf (stores: [asdf-store])
--> KTABLE-TOSTREAM-05
<-- KSTREAM-AGGREGATE-02
Processor: KTABLE-TOSTREAM-05 (stores: [])
--> KSTREAM-SINK-06
<-- asdf
Sink: KSTREAM-SINK-06 (topic: output)
<-- KTABLE-TOSTREAM-05
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-784072487 @mjsax Hello~ Can you help me to take a look? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
