[GitHub] [kafka] gharris1727 commented on pull request #14029: KAFKA-10579: Upgrade reflections from 0.9.12 to 0.10.2
gharris1727 commented on PR #14029: URL: https://github.com/apache/kafka/pull/14029#issuecomment-1642744154 Test failures appear unrelated, and this has passed unit tests, system tests, and stress testing already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] gharris1727 commented on pull request #14029: KAFKA-10579: Upgrade reflections from 0.9.12 to 0.10.2
gharris1727 commented on PR #14029: URL: https://github.com/apache/kafka/pull/14029#issuecomment-1641250195 > Would it be too much to ask to run system tests? I ran the connect system tests on a spare machine and got 181/181 passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] gharris1727 commented on pull request #14029: KAFKA-10579: Upgrade reflections from 0.9.12 to 0.10.2
gharris1727 commented on PR #14029: URL: https://github.com/apache/kafka/pull/14029#issuecomment-1638919826 The license for this changed: ```diff - The license is [WTFPL](http://www.wtfpl.net/), just do what the fuck you want to. + Dual licenced with Apache 2 and [WTFPL](http://www.wtfpl.net/), just do what the fuck you want to. ``` I've added it under both areas in LICENSE-binary, I'm assuming that both licenses apply to the new version but I don't know for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
