[GitHub] [kafka] guozhangwang commented on a change in pull request #10869: KAFKA-10546: Deprecate old PAPI

2021-06-14 Thread GitBox


guozhangwang commented on a change in pull request #10869:
URL: https://github.com/apache/kafka/pull/10869#discussion_r651095121



##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##
@@ -4615,7 +4732,110 @@ void to(final TopicNameExtractor topicExtractor,
  * @see #foreach(ForeachAction)
  * @see #transform(TransformerSupplier, String...)
  */
-void process(final ProcessorSupplier 
processorSupplier,
+ void process(final ProcessorSupplier processorSupplier,
+  final String... stateStoreNames);

Review comment:
   If any template type `K` could bind to `Void` then that seems fine -- I 
was not clear about this myself :P 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on a change in pull request #10869: KAFKA-10546: Deprecate old PAPI

2021-06-14 Thread GitBox


guozhangwang commented on a change in pull request #10869:
URL: https://github.com/apache/kafka/pull/10869#discussion_r650470473



##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##
@@ -4615,7 +4732,110 @@ void to(final TopicNameExtractor topicExtractor,
  * @see #foreach(ForeachAction)
  * @see #transform(TransformerSupplier, String...)
  */
-void process(final ProcessorSupplier 
processorSupplier,
+ void process(final ProcessorSupplier processorSupplier,
+  final String... stateStoreNames);

Review comment:
   Just wondering, if we ended up not doing KAFKA-10603, then how to bound 
`KOut/Vout` to `Void` only?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org