[GitHub] [kafka] guozhangwang commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones
guozhangwang commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r478605835
##
File path:
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##
@@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKTable() {
assertThat(
topology.stateStores().size(),
-equalTo(1));
+equalTo(2));
Review comment:
Ah I see.. what about changing the function as
`enableSendingOldValues(boolean enforced)` in that case? And then only ktable
aggregations which would definitely need this would set it to `true`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones
guozhangwang commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r475792671
##
File path:
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##
@@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKTable() {
assertThat(
topology.stateStores().size(),
-equalTo(1));
+equalTo(2));
Review comment:
`enableSendingOldValues` is indicated for sending a pair of
values, and if it is not set the `old` value would always be null. If we want
to `enableSendingOldValues` then we'd have to materialize the source node still?
Maybe I'm not fully understanding the context here. Could you bring me up to
date?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
