[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-26 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-633667449


   Before this patch, the client.id set in the config file would be overridden.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-24 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-633320764


   I also ran the whole suite locally and only one flaky test in 
`SocketServerTest`. Will merge to trunk.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-21 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632358479


   @xinzhuxiansheng could you run the whole unit test suite locally since 
jenkins seems a bit unstable at the moment? You can run `./gradlew 
cleanTest test`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-21 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632288176


   `test this` is actually a keyword to trigger jenkins job :) But thank you.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-21 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632288255


   test this jenkins



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837772


   test this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837548


   test this



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631810146


   test this



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631755813


   There are known flaky tests that may fail, I'm validating that there's no 
consistent test failures. @xinzhuxiansheng 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox


guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631738575


   test this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org