[GitHub] [kafka] hachikuji commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.
hachikuji commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r436406760 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String, "that the partition is being moved") partitionsWithError += topicPartition +case Errors.UNKNOWN_TOPIC_OR_PARTITION => + warn(s"Remote broker does not host the partition $topicPartition, which could indicate " + +"that the partition is being created or deleted.") Review comment: I don't have a strong opinion on this one. I guess we would most likely see this in startup cases where the remote broker has just started and may not have gotten the full metadata yet. If we fixed that common case, then I think there would be a stronger case to change this to warn. Otherwise, we'd just learn to ignore them in spite of the higher level. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.
hachikuji commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r436406760 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String, "that the partition is being moved") partitionsWithError += topicPartition +case Errors.UNKNOWN_TOPIC_OR_PARTITION => + warn(s"Remote broker does not host the partition $topicPartition, which could indicate " + +"that the partition is being created or deleted.") Review comment: I don't have a strong opinion on this one. I guess we would most likely see this in startup cases where the remote broker may not have gotten the full metadata yet. If we fixed that common case, then I think there would be a stronger case to change this to warn. Otherwise, we'd just learn to ignore them in spite of the higher level. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.
hachikuji commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r436406760 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String, "that the partition is being moved") partitionsWithError += topicPartition +case Errors.UNKNOWN_TOPIC_OR_PARTITION => + warn(s"Remote broker does not host the partition $topicPartition, which could indicate " + +"that the partition is being created or deleted.") Review comment: I don't have a strong opinion on this one. I guess we would most likely see this in startup cases where the remote broker may not have gotten the full metadata yet. If we fixed that common case, then I think there would be a strong case to change this to warn. Otherwise, we'd just learn to ignore them in spite of the higher level. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
