[GitHub] [kafka] hachikuji commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-09-25 Thread GitBox 


hachikuji commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-699081923


   @ableegoldman I agree it would be useful to have a test case. If you have 
time, maybe you can help out in a follow-up?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] hachikuji commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-09-28 Thread GitBox 


hachikuji commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-700349997


   @nym3r0s Take a look at 
`SenderTest.testForceShutdownWithIncompleteTransaction`. I think we could add a 
similar test which aborts the transaction directly before the Produce request 
has been sent. Let us know if you don't have time within the next couple weeks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org