[GitHub] [kafka] highluck commented on a change in pull request #9861: MINOR: Modify unnecessary access specifiers

[GitBox]

highluck commented on a change in pull request #9861:
URL: https://github.com/apache/kafka/pull/9861#discussion_r615971825



##
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java
##
@@ -96,7 +96,7 @@ public boolean putIfDifferentValues(final K key,
 public static class RawAndDeserializedValue {

Review comment:
   @chia7712 The code has been modified!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] highluck commented on a change in pull request #9861: MINOR: Modify unnecessary access specifiers

[GitBox]

highluck commented on a change in pull request #9861:
URL: https://github.com/apache/kafka/pull/9861#discussion_r613861045



##
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -104,7 +104,7 @@
 private final RocksDBMetricsRecorder metricsRecorder;
 
 // visible for testing

Review comment:
   Thanks for the comment.
   That part doesn't seem necessary.
   And I think you can clear that field.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org