hudeqi opened a new pull request, #13617: URL: https://github.com/apache/kafka/pull/13617
1. add hint in switch item "BROKER_LOGGER" in ConfigResourceExistenceChecker, otherwise, it will be classified as default break and deleted directly. I don’t know if adding hint is better than deleting directly. 2. The ”generateSnapshotScheduled“ member variable in QuorumController is given a default value but has never been used. Is it better to change it to a final type and give a default value during initialization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org