[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575719316 ## File path: checkstyle/import-control.xml ## @@ -69,6 +69,17 @@ + + + + + + + + Review comment: Addressed this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575719312 ## File path: checkstyle/import-control.xml ## @@ -144,15 +155,14 @@ - + Review comment: This affects a lot of files and I'd rather do that in a separate PR as I may backport this one to stable branches. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575703770 ## File path: checkstyle/import-control.xml ## @@ -144,15 +155,14 @@ - + Review comment: Possibly. Let me see what other impact it has. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575703615 ## File path: checkstyle/import-control.xml ## @@ -69,6 +69,17 @@ + + + + + + + + Review comment: That's a good point. It probably means we need to move BufferSupplier to another package to avoid circular dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
