[GitHub] [kafka] ijuma commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

2022-05-02 Thread GitBox


ijuma commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r862968313


##
docs/upgrade.html:
##
@@ -73,7 +73,11 @@ Notable changes in 3
 via Connect worker and/or connector configuration. Connect may 
enable idempotent producers
 by default in a future major release.
 Kafka has replaced log4j and slf4j-log4j12 with reload4j and 
slf4j-reload4j due to security concerns.

Review Comment:
   We should also update the same text in the 3.1 branch once we merge this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] ijuma commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

2022-05-02 Thread GitBox


ijuma commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r862967880


##
docs/upgrade.html:
##
@@ -73,7 +73,11 @@ Notable changes in 3
 via Connect worker and/or connector configuration. Connect may 
enable idempotent producers
 by default in a future major release.
 Kafka has replaced log4j and slf4j-log4j12 with reload4j and 
slf4j-reload4j due to security concerns.

Review Comment:
   Maybe we can say something like:
   
   > Kafka has replaced log4j and slf4j-log4j12 with reload4j and 
slf4j-reload4j due to security concerns.
   >  This only affects modules that specify a logging backend 
(`connect-runtime` and `kafka-tools` are two such
   >  examples). A number of modules, including `kafka-clients`, 
leave it to the application to specify the logging
   >  backend. More information can be found at https://reload4j.qos.ch;>reload4j.
   > Projects that depend on the affected modules from the Kafka 
project should use
   > https://www.slf4j.org/manual.html#swapping;>slf4j-log4j12 version 1.7.35 
or above or
   > slf4j-reload4j to avoid
   > https://www.slf4j.org/codes.html#no_tlm;>possible 
compatibility issues originating from the logging framework.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org