[GitHub] [kafka] ijuma commented on pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module
ijuma commented on PR #13049: URL: https://github.com/apache/kafka/pull/13049#issuecomment-1370775605 I went ahead and merged this to unblock other PRs, but happy to follow up if @mimaison or @junrao have additional comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module
ijuma commented on PR #13049: URL: https://github.com/apache/kafka/pull/13049#issuecomment-1370081626 @mimaison Thanks for the review. I addressed or replied to each comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module
ijuma commented on PR #13049: URL: https://github.com/apache/kafka/pull/13049#issuecomment-1369088571 @satishd If you have cycles, this PR is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module
ijuma commented on PR #13049: URL: https://github.com/apache/kafka/pull/13049#issuecomment-1366926066 JDK 8 and JDK 11 builds passed, JDK 17 had one unrelated failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org