[GitHub] [kafka] ijuma commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783
ijuma commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508573002 The PR build has 95 failures: > Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testCreatePartitionsUseProvidedForwardingAdmin() Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testSyncTopicConfigUseProvidedForwardingAdmin() Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testCreatePartitionsUseProvidedForwardingAdmin() Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testSyncTopicConfigUseProvidedForwardingAdmin() Build / JDK 17 and Scala 2.13 / kafka.security.authorizer.AuthorizerTest.testAuthorizeWithPrefixedResource(String).quorum=kraft Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState() Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testCreatePartitionsUseProvidedForwardingAdmin() Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testSyncTopicConfigUseProvidedForwardingAdmin() Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testCreatePartitionsUseProvidedForwardingAdmin() Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testSyncTopicConfigUseProvidedForwardingAdmin() Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration Build / JDK 8 and Scala 2.12 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor() Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures() Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.executionError Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerWithLegacyMessageFormatIntegrationTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.DelegationTokenEndToEndAuthorizationTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.EndToEndClusterIdTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.GroupCoordinatorIntegrationTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.LogAppendTimeTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.PlaintextConsumerTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.PlaintextEndToEndAuthorizationTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.ProducerFailureHandlingTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.ProducerSendWhileDeletionTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.SaslClientsWithInvalidCredentialsTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.SaslGssapiSslEndToEndAuthorizationTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.SaslOAuthBearerSslEndToEndAuthorizationTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.SaslPlaintextConsumerTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.SaslSslConsumerTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.SslConsumerTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.SslProducerSendTest.initializationError Build / JDK 8 and Scala 2.12 / kafka.api.TransactionsBounceTest.initializationError Build /
[GitHub] [kafka] ijuma commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783
ijuma commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508774105 But how do we even know that this is helping vs making it worse with so many failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783
ijuma commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508828513 @gharris1727 I think what you did was fine. :) My concern is more on how we decided that it was ok to merge. I looked a bit more and I think the issues potentially started around here for a bunch of the tests: https://github.com/apache/kafka/pull/13373#issuecomment-1508823431 And it looks like a similar pattern happened there where we merged without a detailed analysis of the failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org