[GitHub] [kafka] ijuma commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-09-08 Thread GitBox 


ijuma commented on pull request #9182:
URL: https://github.com/apache/kafka/pull/9182#issuecomment-688916053


   The change looks good, can you please provide a test as well?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-08-14 Thread GitBox 


ijuma commented on pull request #9182:
URL: https://github.com/apache/kafka/pull/9182#issuecomment-674160788


   Can you please include more detail on how it fails currently? I assume it's 
some kind of deserialization error?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org