[GitHub] [kafka] ijuma commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-17 Thread GitBox 


ijuma commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728974716


   Thanks @chia7712. Can you check that the @hachikuji's perf test doesn't 
result in significantly increased latency?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-16 Thread GitBox 


ijuma commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728531187


   That is really weird. The difference seems significant enough that we need 
to understand it better before we can merge IMO.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-16 Thread GitBox 


ijuma commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-728385188


   Nice! So what's the reason for the small regression in the PR description?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-08 Thread GitBox 


ijuma commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-723675299


   Can we summarize the regression here for a real world workload?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org