[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-772381544 I was talking about build 17 (triggered by Commit db573f5, see https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9107/) Where did build 18 came from, why it took 8 hours and then timed out -- I can't understand This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-771925298 Hi @mjsax , I have rebased and manually merged conflicts, and also removed `FunctionConverters` JDK8 build still fails, but this time much later -- something related to integration testing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-771925298 Hi @mjsax , I have rebased and manually merged conflicts, and also removed `FunctionConverters` JDK8 build still fails, but this time much later -- something related to integration testing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-769038641 Hi @mjsax , I have implemented all your suggestions concerning Javadocs/Scaladocs. After rebasing, there are less failing tests I also see that `JDK8` build continues to fail because of Scala compilation issue. AFAICS, that's because we are using `FunctionWrappers` object which is not available in older versions of Scala. Is it OK? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-768769254 > @inponomarev the failing tests seems to be due to a known issue that was fixed via #9768 > > Can you rebase your PR to pickup the fix so we can get a green build? Done rebasing, expect the fixes according to your latest review soon! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-762937808 Ooops, I just noticed one more thing to fix: https://github.com/apache/kafka/blob/3b7dda459ca9a1bcea72ca981c2a19a4ccffe9f2/streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java#L115 Will push a new commit today or tomorrow! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-762931868 Thank you @vvcephei, I have updated [the KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-418%3A+A+method-chaining+way+to+branch+KStream) and now it reflects the actual implementation. I just wasn't sure if it's ok to edit specification text after it has been formally approved :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-761803551 Hi @vvcephei thank you for your commits! Is everything else OK, especially https://github.com/apache/kafka/pull/9107#issuecomment-666749809? @mjsax I pushed small fixes to Javadoc/Scaladoc, and AFAICS only tests not related to the changes are failing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-759644375 @vvcephei @mjsax I added full Scala wrapper for the new API: `split` method, `BranchedKStream` and `Branched`. Also added Scala unit tests that verify main use cases This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-758218461 Hi @vvcephei , thank you for your comment. There's another question that we were unable to solve without you -- see https://github.com/apache/kafka/pull/9107#issuecomment-752098770 from the words 'CI checks fail' and further discussion. Can you clarify, what's expected from `KStream.scala` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-752382595 As far as I can judge from the name, `@nowarn` is not for deprecation, but rather for a warning suppression 樂 apparently we need to mirror the changes in Java `KStream` interface here. Never wrote anything in Scala before. OK, it's better to wait for @vvcephei ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-752098770 > Can you also update the docs for Kafka Streams and the 2.8 upgrade guide in this PR. The documentation had been already updated (see changes in `docs/streams/developer-guide/dsl-api.html`) I also modified `docs/upgrade.html` -- should I add something more here, like code examples? Another question: CI checks fail because of usage of deprecated `branch` method in `streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala`. Since I'm not a Scala user, I have no idea of what should be done here. Most likely we should deprecate the `branch` method and add a wrapper for the new `split` method, but I don't know how to do this correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
