[GitHub] [kafka] jeqo commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-20 Thread GitBox 


jeqo commented on pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#issuecomment-677489429


   @vvcephei thanks for your feedback! Inverting flag actually make things more 
readable. Changing to `forward` and `if (forward) {} else {}`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jeqo commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-13 Thread GitBox 


jeqo commented on pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#issuecomment-673574377


   @ableegoldman this should be ready for another review :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jeqo commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-08 Thread GitBox 


jeqo commented on pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#issuecomment-670850075


   cc @ableegoldman 
   
   This PR is ready for review, covering related feedback from #8976



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org