[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox 


jlprat commented on a change in pull request #10780:
URL: https://github.com/apache/kafka/pull/10780#discussion_r640844354



##
File path: release.py
##
@@ -512,6 +512,7 @@ def command_release_announcement_email():
 
 jdk8_env = get_jdk(prefs, 8)
 jdk11_env = get_jdk(prefs, 11)

Review comment:
   Pushed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox 


jlprat commented on a change in pull request #10780:
URL: https://github.com/apache/kafka/pull/10780#discussion_r640843605



##
File path: release.py
##
@@ -512,6 +512,7 @@ def command_release_announcement_email():
 
 jdk8_env = get_jdk(prefs, 8)
 jdk11_env = get_jdk(prefs, 11)

Review comment:
   The only reference was at line 604, which I replaced for JDK15




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox 


jlprat commented on a change in pull request #10780:
URL: https://github.com/apache/kafka/pull/10780#discussion_r640842878



##
File path: release.py
##
@@ -512,6 +512,7 @@ def command_release_announcement_email():
 
 jdk8_env = get_jdk(prefs, 8)
 jdk11_env = get_jdk(prefs, 11)

Review comment:
   I will push a commit without this line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox 


jlprat commented on a change in pull request #10780:
URL: https://github.com/apache/kafka/pull/10780#discussion_r640841969



##
File path: release.py
##
@@ -512,6 +512,7 @@ def command_release_announcement_email():
 
 jdk8_env = get_jdk(prefs, 8)
 jdk11_env = get_jdk(prefs, 11)

Review comment:
   Most probably, but I never executed that part of the script.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jlprat commented on a change in pull request #10780: KAFKA-12782: Fix Javadocs generation by upgrading JDK

2021-05-27 Thread GitBox 


jlprat commented on a change in pull request #10780:
URL: https://github.com/apache/kafka/pull/10780#discussion_r640840181



##
File path: release.py
##
@@ -265,7 +265,7 @@ def command_stage_docs():
 # version due to already having bumped the bugfix version number.
 gradle_version_override = docs_release_version(version)
 
-cmd("Building docs", "./gradlew -Pversion=%s clean siteDocsTar 
aggregatedJavadoc" % gradle_version_override, cwd=REPO_HOME, env=jdk11_env)
+cmd("Building docs", "./gradlew -Pversion=%s clean siteDocsTar 
aggregatedJavadoc" % gradle_version_override, cwd=REPO_HOME, env=jdk15_env)

Review comment:
   This, together with change in line 259, are the changes needed

##
File path: release.py
##
@@ -600,7 +601,7 @@ def select_gpg_key():
 
 cmd("Building artifacts", "./gradlew clean && ./gradlewAll releaseTarGz", 
cwd=kafka_dir, env=jdk8_env, shell=True)
 cmd("Copying artifacts", "cp %s/core/build/distributions/* %s" % (kafka_dir, 
artifacts_dir), shell=True)
-cmd("Building docs", "./gradlew clean aggregatedJavadoc", cwd=kafka_dir, 
env=jdk11_env)
+cmd("Building docs", "./gradlew clean aggregatedJavadoc", cwd=kafka_dir, 
env=jdk15_env)

Review comment:
   This one I'm not sure it's really needed as I never executed that part 
of the script.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org