[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

2021-05-27 Thread GitBox


jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-849486858


   Thanks for the review @cadonna !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

2021-05-17 Thread GitBox


jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-842288466






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

2021-05-17 Thread GitBox


jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-842510628


   As discussed with @ableegoldman only classes deprecated since at least 2.5 
can be removed. For this reason, `Serdes` can't be removed yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] jlprat commented on pull request #10710: KAFKA-12796: Removal of deprecated classes under `streams-scala`

2021-05-17 Thread GitBox


jlprat commented on pull request #10710:
URL: https://github.com/apache/kafka/pull/10710#issuecomment-842288466


   cc @cadonna PR is ready for review, if you would like to take a look. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org