[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910482302 Thanks for the reviews @guozhangwang and @cadonna ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910048239 Ping @cadonna and @guozhangwang Is there anything else you'd like changed in the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-910048239 Ping @cadonna and @guozhangwang Is there anything else you'd like changed in the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-908365423 Test failure is related to https://issues.apache.org/jira/browse/KAFKA-8138 but not the same, as in this particular instance it seems more like a failure in the test itself (topic already exists) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-908365423 Test failure is related to https://issues.apache.org/jira/browse/KAFKA-8138 but not the same, as in this particular instance it seems more like a failure in the test itself (topic already exists) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-908160013 @cadonna Applied your feedback as well, thanks for the comments. I also realized the `AtomicBoolean` variables in the test could be final and added that as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-90213 Current failure is https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11228/5/testReport/org.apache.kafka.streams.integration/NamedTopologyIntegrationTest/Build___JDK_8_and_Scala_2_12___shouldAllowPatternSubscriptionWithMultipleNamedTopologies/ But it doesn't seem related to the changes in this PR. I would say it seems a newly found regression (there isn't a ticket yet). Any opinions @cadonna @guozhangwang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-906570612 Tests failures seem related, I will investigate them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-906397381 Ping @cadonna and @guozhangwang Let me know what you think about this version. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-903309159 Thanks for your feedback @guozhangwang I thought "simply" killing the thread was the original intention. I'll look into killing the whole instance once @cadona provides his feedback on this (just in case there isn't something easy to overlook) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-902529232 Reopening to re-trigger CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-901030641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-901123276 Test failure was https://issues.apache.org/jira/browse/KAFKA-8529 which was apparently resolved. I reopened the issue. I rebased this PR to the trunk of a couple of hours ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-901030641 cc. @guozhangwang Feel free to review this PR and let me know if this is what you had in mind with https://issues.apache.org/jira/browse/KAFKA-12887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
