[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270114193
##
tests/kafkatest/version.py:
##
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
I think the issue in David's commit was that he didn't set the dev version
to match the new version defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##
tests/kafkatest/version.py:
##
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits, we've added this cutting the
release branch for the previous version. (Ie, cutting the branch for the new
trunk as per the commit comments) Seems like the top commit I linked should not
have been reverted unless all of these were wrong.
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##
tests/kafkatest/version.py:
##
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits, we've added this cutting the
release branch for the previous version. (Ie, cutting the branch for the new
trunk as per the commit comments)
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##
tests/kafkatest/version.py:
##
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits we've added this cutting the
release branch for the previous version. (Ie, cutting the branch for the new
trunk as per the commit comments)
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505
##
tests/kafkatest/version.py:
##
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Hmm -- if you look at all the snapshot commits we've added this upon
releasing the previous version. (Ie, cutting the branch for the new trunk as
per the commit comments)
https://github.com/apache/kafka/commit/dc1ede8d89d0964783302e0da9ead7fa1d76fbe4
https://github.com/apache/kafka/commit/c1a54671e8fc6c7daec5f5ec3d8c934be96b4989
https://github.com/apache/kafka/commit/6ace67b2de00f4f1665e7c9e3484e01b6d6f9584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test
jolshan commented on code in PR #13654:
URL: https://github.com/apache/kafka/pull/13654#discussion_r1270009709
##
tests/kafkatest/version.py:
##
@@ -249,7 +250,3 @@ def get_version(node=None):
# 3.5.x versions
V_3_5_0 = KafkaVersion("3.5.0")
LATEST_3_5 = V_3_5_0
-
-# 3.6.x versions
-V_3_6_0 = KafkaVersion("3.6.0")
Review Comment:
Here -- did we mean to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
