[GitHub] [kafka] jolshan commented on pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…
jolshan commented on pull request #10269: URL: https://github.com/apache/kafka/pull/10269#issuecomment-802975219 >sounds good. If the new approach is very different from #9944, please open a new PR in order to compare them :) @chia7712 I've updated the code. I think this is the direction we want so I didn't open a PR. Biggest changes to the structure are in these commits: https://github.com/apache/kafka/pull/9944/commits/5a0a6d6a9e34a77e7da8b2b320b52fdc589c2e8d https://github.com/apache/kafka/pull/9944/commits/a0b2bc96b125d08cb4b9d47c6826e60a85cae968 https://github.com/apache/kafka/pull/9944/commits/ace90b07d46a596b0d630b4ff8821a81eb1a01e4 The idea is that FetchSession can now generate a list of the unresolvedTopics' `FetchResponseData.FetchableTopicResponse`. Hopefully from there, it is not too difficult to combine with your approach here. But let me know if it's hard to read. I can open a new one and revert the changes on the old. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…
jolshan commented on pull request #10269: URL: https://github.com/apache/kafka/pull/10269#issuecomment-801187849 @chia7712 I'm rewriting https://github.com/apache/kafka/pull/9944 to use the autogenerated structures based on this PR. Just pushed a version that simplifies the unresolved topic ID handling. I tried to make it easier to build the fetch response using the data object. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…
jolshan commented on pull request #10269: URL: https://github.com/apache/kafka/pull/10269#issuecomment-800648300 @chia7712 is there any work in progress for a KafkaApis.handleFetchRequest test? I suspect it would be similar but maybe a bit harder than what I did for the LeaderAndIsr version https://github.com/apache/kafka/pull/10071 (trading replicamanager for fetchmanager, etc). This benchmark would be helpful for https://github.com/apache/kafka/pull/9944 as you could probably guess :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
