[GitHub] [kafka] jolshan commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found
jolshan commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1710766397 Tests look unrelated and like flakes I've seen before, so I will go ahead and merge + pick to 3.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found
jolshan commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1710539538 Also -- I assume we want to pick this to 3.6 as well. Is that the only branch @C0urante? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found
jolshan commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1707306276 Sorry for the delay @C0urante and thanks for the explanation. It makes sense. Given that we moved the retries to `TopicAdmin::retryEndOffsets` does this mean there is not any known wide usage or need for this retry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found
jolshan commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1701899168 What was the original rationale for https://issues.apache.org/jira/browse/KAFKA-12339? My understanding is that when a topic is first created, there is sometimes a delay to the metadata propagation. It seems like connect was encountering this issue and rather than adding code to retry they wanted it to be done automatically. I can see the issue with the compatibility break, but I also see the issue with the metadata propagation. Is there anyway to configure whether we prefer to retry on such an error? Or is the argument this should always be left to the client to handle the manual retries? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
