[GitHub] [kafka] joobisb commented on pull request #13862: KAFKA-15050: format the prompts in the quickstart
joobisb commented on PR #13862: URL: https://github.com/apache/kafka/pull/13862#issuecomment-1624188820 @tombentley could you please have a look, have addressed the comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] joobisb commented on pull request #13862: KAFKA-15050: format the prompts in the quickstart
joobisb commented on PR #13862: URL: https://github.com/apache/kafka/pull/13862#issuecomment-1603798251 > @mimaison mentioned in a separate conversation a couple of other points: > > 1. it looks like we never need to refer to any of the example lines of console input/output using the line numbers, so perhaps we can get rid of the line number for shell command blocks (to it's less visually busy). > 2. the console producer example is also missing the `>` prompts, maybe we can add them as part of this PR too @tombentley @mimaison I've addressed the comments, please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] joobisb commented on pull request #13862: KAFKA-15050: format the prompts in the quickstart
joobisb commented on PR #13862: URL: https://github.com/apache/kafka/pull/13862#issuecomment-1595663538 @tombentley have addressed the comments, please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
