[GitHub] [kafka] jsancio commented on a diff in pull request #12245: KAFKA-13410; Add a --release-version flag for storage-tool

[GitBox]

jsancio commented on code in PR #12245:
URL: https://github.com/apache/kafka/pull/12245#discussion_r891557424


##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -97,9 +97,9 @@ object StorageTool extends Logging {
   help("The cluster ID to use.")
 formatParser.addArgument("--ignore-formatted", "-g").
   action(storeTrue())
-formatParser.addArgument("--metadata-version", "-v").

Review Comment:
   We don't need to deprecate this because this version of the storage tool was 
never released, right? `git tag --contains` doesn't show any reference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jsancio commented on a diff in pull request #12245: KAFKA-13410; Add a --release-version flag for storage-tool

[GitBox]

jsancio commented on code in PR #12245:
URL: https://github.com/apache/kafka/pull/12245#discussion_r889255627


##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -162,7 +163,7 @@ Found problem:
   val stream = new ByteArrayOutputStream()
   assertEquals(0, StorageTool.
 formatCommand(new PrintStream(stream), Seq(tempDir.toString), 
metaProperties, MetadataVersion.latest(), ignoreFormatted = false))
-  assertEquals("Formatting %s%n".format(tempDir), stream.toString())
+  assertTrue(stream.toString().startsWith("Formatting %s".format(tempDir)))

Review Comment:
   Minor but you can use Scala string interpolation. E.g. `s"Formatting 
$tempDir"`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org