[GitHub] [kafka] jsancio commented on a diff in pull request #13396: KAFKA-13884; Only voters flush on Fetch response

[via GitHub]

jsancio commented on code in PR #13396:
URL: https://github.com/apache/kafka/pull/13396#discussion_r1136211424


##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -975,6 +980,18 @@ void assertFetchRequestData(
 assertEquals(fetchOffset, fetchPartition.fetchOffset());
 assertEquals(lastFetchedEpoch, fetchPartition.lastFetchedEpoch());
 assertEquals(localId.orElse(-1), request.replicaId());
+
+// Assert that voters have flushed up to the fetch offset
+if (localId.isPresent() && voters.contains(localId.getAsInt())) {

Review Comment:
   Okay. Added a check for observers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] jsancio commented on a diff in pull request #13396: KAFKA-13884; Only voters flush on Fetch response

[via GitHub]

jsancio commented on code in PR #13396:
URL: https://github.com/apache/kafka/pull/13396#discussion_r1136182878


##
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##
@@ -975,6 +980,18 @@ void assertFetchRequestData(
 assertEquals(fetchOffset, fetchPartition.fetchOffset());
 assertEquals(lastFetchedEpoch, fetchPartition.lastFetchedEpoch());
 assertEquals(localId.orElse(-1), request.replicaId());
+
+// Assert that voters have flushed up to the fetch offset
+if (localId.isPresent() && voters.contains(localId.getAsInt())) {

Review Comment:
   Yeah. I am not sure. Not sure if we should check for "performance" in the 
correctness tests.
   
   I am also not sure what we would check for either. For example, I can add a 
boolean to `MockLog` that gets set to `true` on flush and set to `false` when 
`RaftClientTextContext` checks it.
   
   What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org