[GitHub] [kafka] jsancio commented on pull request #13668: KAFKA-14963; Use equals method with Uuid

2023-05-03 Thread via GitHub


jsancio commented on PR #13668:
URL: https://github.com/apache/kafka/pull/13668#issuecomment-1533476771

   Uuid is an object so they need to be compared with the equals method and not 
the == operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] jsancio commented on pull request #13668: KAFKA-14963; Use equals method with Uuid

2023-05-03 Thread via GitHub


jsancio commented on PR #13668:
URL: https://github.com/apache/kafka/pull/13668#issuecomment-1533473126

   Thanks for the reviews. The following command passes:
   ```bash
   $ ./gradlew metadata:test
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org