[GitHub] [kafka] junrao commented on a change in pull request #11154: KAFKA-13068: Rename Log to UnifiedLog
junrao commented on a change in pull request #11154:
URL: https://github.com/apache/kafka/pull/11154#discussion_r683680502
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1738,12 +1747,12 @@ object Log extends Logging {
logDirFailureChannel: LogDirFailureChannel,
lastShutdownClean: Boolean = true,
topicId: Option[Uuid],
-keepPartitionMetadataFile: Boolean): Log = {
+keepPartitionMetadataFile: Boolean): UnifiedLog = {
// create the log directory if it doesn't exist
Files.createDirectories(dir.toPath)
-val topicPartition = Log.parseTopicPartitionName(dir)
+val topicPartition = UnifiedLog.parseTopicPartitionName(dir)
val segments = new LogSegments(topicPartition)
-val leaderEpochCache = Log.maybeCreateLeaderEpochCache(
+val leaderEpochCache = UnifiedLog.maybeCreateLeaderEpochCache(
Review comment:
Should we change the logging prefix to UnifiedLog in line 1760 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] junrao commented on a change in pull request #11154: KAFKA-13068: Rename Log to UnifiedLog
junrao commented on a change in pull request #11154:
URL: https://github.com/apache/kafka/pull/11154#discussion_r682801773
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -248,16 +250,16 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
* will be deleted to avoid ID conflicts upon
re-upgrade.
*/
@threadsafe
-class Log(@volatile var logStartOffset: Long,
- private val localLog: LocalLog,
- brokerTopicStats: BrokerTopicStats,
- val producerIdExpirationCheckIntervalMs: Int,
- @volatile var leaderEpochCache: Option[LeaderEpochFileCache],
- val producerStateManager: ProducerStateManager,
- @volatile private var _topicId: Option[Uuid],
- val keepPartitionMetadataFile: Boolean) extends Logging with
KafkaMetricsGroup {
+class UnifiedLog(@volatile var logStartOffset: Long,
+ private val localLog: LocalLog,
+ brokerTopicStats: BrokerTopicStats,
+ val producerIdExpirationCheckIntervalMs: Int,
+ @volatile var leaderEpochCache: Option[LeaderEpochFileCache],
+ val producerStateManager: ProducerStateManager,
+ @volatile private var _topicId: Option[Uuid],
+ val keepPartitionMetadataFile: Boolean) extends Logging with
KafkaMetricsGroup {
- import kafka.log.Log._
+ import kafka.log.UnifiedLog._
Review comment:
Should we rename the logging prefix to UnifiedLog too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] junrao commented on a change in pull request #11154: KAFKA-13068: Rename Log to UnifiedLog
junrao commented on a change in pull request #11154:
URL: https://github.com/apache/kafka/pull/11154#discussion_r682801773
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -248,16 +250,16 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
* will be deleted to avoid ID conflicts upon
re-upgrade.
*/
@threadsafe
-class Log(@volatile var logStartOffset: Long,
- private val localLog: LocalLog,
- brokerTopicStats: BrokerTopicStats,
- val producerIdExpirationCheckIntervalMs: Int,
- @volatile var leaderEpochCache: Option[LeaderEpochFileCache],
- val producerStateManager: ProducerStateManager,
- @volatile private var _topicId: Option[Uuid],
- val keepPartitionMetadataFile: Boolean) extends Logging with
KafkaMetricsGroup {
+class UnifiedLog(@volatile var logStartOffset: Long,
+ private val localLog: LocalLog,
+ brokerTopicStats: BrokerTopicStats,
+ val producerIdExpirationCheckIntervalMs: Int,
+ @volatile var leaderEpochCache: Option[LeaderEpochFileCache],
+ val producerStateManager: ProducerStateManager,
+ @volatile private var _topicId: Option[Uuid],
+ val keepPartitionMetadataFile: Boolean) extends Logging with
KafkaMetricsGroup {
- import kafka.log.Log._
+ import kafka.log.UnifiedLog._
Review comment:
Should we rename the logging prefix to UnifiedLog too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
