[GitHub] [kafka] junrao commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module
junrao commented on code in PR #13304:
URL: https://github.com/apache/kafka/pull/13304#discussion_r1123584048
##
storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java:
##
@@ -44,6 +45,28 @@ public FetchDataInfo(LogOffsetMetadata fetchOffsetMetadata,
this.abortedTransactions = abortedTransactions;
}
+@Override
+public boolean equals(Object o) {
+if (this == o) return true;
+if (o == null || getClass() != o.getClass()) return false;
+
+FetchDataInfo that = (FetchDataInfo) o;
+
+return firstEntryIncomplete != that.firstEntryIncomplete &&
+Objects.equals(fetchOffsetMetadata, that.fetchOffsetMetadata)
&&
+Objects.equals(records, that.records) &&
Review Comment:
Hmm, FileRecords doesn't implement `equals`. So, maybe LogReadInfo should
never be used for comparison?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] junrao commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module
junrao commented on code in PR #13304:
URL: https://github.com/apache/kafka/pull/13304#discussion_r1120915339
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.storage.internals.log;
+
+import org.apache.kafka.common.message.FetchResponseData;
+
+import java.util.Objects;
+import java.util.Optional;
+
+/**
+ * Structure used for lower level reads using {@link
kafka.cluster.Partition#fetchRecords()}.
+ */
+public class LogReadInfo {
+
+public final FetchDataInfo fetchedData;
+public final Optional divergingEpoch;
+public final long highWatermark;
+public final long logStartOffset;
+public final long logEndOffset;
+public final long lastStableOffset;
+
+public LogReadInfo(FetchDataInfo fetchedData,
Review Comment:
Should we define `equals()` and `hashCode()` for FetchDataInfo too?
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetSnapshot.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.storage.internals.log;
+
+/**
+ * Container class which represents a snapshot of the significant offsets for
a partition. This allows fetching
+ * of these offsets atomically without the possibility of a leader change
affecting their consistency relative
+ * to each other. See {@link UnifiedLog#fetchOffsetSnapshot()}.
+ */
+public class LogOffsetSnapshot {
Review Comment:
Should we define equals() and hashCode()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] junrao commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module
junrao commented on code in PR #13304:
URL: https://github.com/apache/kafka/pull/13304#discussion_r1119112476
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1434,13 +1434,13 @@ class Partition(val topicPartition: TopicPartition,
minOneMessage
)
-LogReadInfo(
- fetchedData = fetchedData,
- divergingEpoch = None,
- highWatermark = initialHighWatermark,
- logStartOffset = initialLogStartOffset,
- logEndOffset = initialLogEndOffset,
- lastStableOffset = initialLastStableOffset
+new LogReadInfo(
+ fetchedData,
+ Optional.empty[FetchResponseData.EpochEndOffset](),
Review Comment:
Could we just do `Optional.empty()`?
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.storage.internals.log;
+
+import org.apache.kafka.common.message.FetchResponseData;
+
+import java.util.Optional;
+
+/**
+ * Structure used for lower level reads using {@link
kafka.cluster.Partition#fetchRecords()}.
+ */
+public class LogReadInfo {
Review Comment:
All scala case classes define `equal()` and `hashcode()`. Do we need to
define those explicitly in java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
