[GitHub] [kafka] junrao commented on a diff in pull request #13454: MINOR: move RecordReader from org.apache.kafka.tools to org.apache.co…
junrao commented on code in PR #13454:
URL: https://github.com/apache/kafka/pull/13454#discussion_r1158997043
##
tools/tools-api/src/test/java/org/apache/kafka/tools/api/RecordReaderTest.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools.api;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+public class RecordReaderTest {
+
+@Test
+void testDefaultCloseAndConfigure() {
Review Comment:
What do we test in this unit test? There is no assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] junrao commented on a diff in pull request #13454: MINOR: move RecordReader from org.apache.kafka.tools to org.apache.co…
junrao commented on code in PR #13454:
URL: https://github.com/apache/kafka/pull/13454#discussion_r1158757537
##
build.gradle:
##
@@ -858,6 +858,7 @@ project(':core') {
implementation project(':group-coordinator')
implementation project(':metadata')
implementation project(':storage:api')
+implementation project(':tools:tools-api')
Review Comment:
Why does core depend on tools-api?
##
build.gradle:
##
@@ -1766,13 +1769,69 @@ project(':storage') {
}
}
+project(':tools:tools-api') {
Review Comment:
Should we change the javadoc part to include the tools.api package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] junrao commented on a diff in pull request #13454: MINOR: move RecordReader from org.apache.kafka.tools to org.apache.co…
junrao commented on code in PR #13454: URL: https://github.com/apache/kafka/pull/13454#discussion_r1156500801 ## clients/src/main/java/org/apache/kafka/common/RecordReader.java: ## @@ -14,10 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.kafka.tools; +package org.apache.kafka.common; Review Comment: Another possibility is to move this to the tools module under the package org.apache.kafka.tools.api, which seems a bit cleaner? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
