[GitHub] [kafka] junrao commented on pull request #1864: KAFKA-4177: Remove ThrottledReplicationRateLimit from Server Config

2023-07-12 Thread via GitHub


junrao commented on PR #1864:
URL: https://github.com/apache/kafka/pull/1864#issuecomment-1633289594

   @nkostoulas : Since this requires a config change, it will need a KIP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] junrao commented on pull request #1864: KAFKA-4177: Remove ThrottledReplicationRateLimit from Server Config

2023-07-07 Thread via GitHub


junrao commented on PR #1864:
URL: https://github.com/apache/kafka/pull/1864#issuecomment-1626345380

   @nkostoulas : My vague recollection is that for 
ThrottledReplicationRateLimit to take effect, we need to set 
[leader.replication.throttled.replicas](https://kafka.apache.org/documentation/#topicconfigs_leader.replication.throttled.replicas)
 and 
[follower.replication.throttled.replicas](https://kafka.apache.org/documentation/#topicconfigs_follower.replication.throttled.replicas).
 At the point, we didn't support `*` for those configs. So, there wasn't a good 
static default. We have since added the support for `*`. So, we could revisit 
this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org