[GitHub] [kafka] kamalcph commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-04 Thread GitBox


kamalcph commented on pull request #10602:
URL: https://github.com/apache/kafka/pull/10602#issuecomment-892406838


   @vvcephei 
   Thanks for figuring out the issue. Feel free to take over this patch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kamalcph commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-07-08 Thread GitBox


kamalcph commented on pull request #10602:
URL: https://github.com/apache/kafka/pull/10602#issuecomment-876277111


   @vvcephei 
   Resolved the conflicts. Ran the below tests:
   
   ```
   ./gradlew :streams:testAll
TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py" bash 
tests/docker/run_tests.sh
   ```
   Please take a look when you get a chance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kamalcph commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-07-06 Thread GitBox


kamalcph commented on pull request #10602:
URL: https://github.com/apache/kafka/pull/10602#issuecomment-875230369


   > Hi @kamalcph , what's the status of this PR? I noticed there are some 
unresolved code review comments, and there are some conflicts.
   
   I'll address the pending review comments and resolve the conflicts. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kamalcph commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-04-28 Thread GitBox


kamalcph commented on pull request #10602:
URL: https://github.com/apache/kafka/pull/10602#issuecomment-828471522


   @chia7712 @mjsax @ijuma 
   Ping for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org