[GitHub] [kafka] kamalcph commented on pull request #13837: KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager
kamalcph commented on PR #13837: URL: https://github.com/apache/kafka/pull/13837#issuecomment-1637897271 > > We can work on appending the offset as prefix to the remote log file-set in the next framework PR. Thanks! > > @kamalcph Sure, this can be done in other PR. Please file a JIRA if you have not yet so that we will not miss it. Filed https://issues.apache.org/jira/browse/KAFKA-15194 to track this separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #13837: KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager
kamalcph commented on PR #13837: URL: https://github.com/apache/kafka/pull/13837#issuecomment-1637702477 @jeqo @showuon @satishd Addressed your review comments. PTAL. We can work on appending the offset as prefix to the remote log file-set in the next framework PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #13837: KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager
kamalcph commented on PR #13837: URL: https://github.com/apache/kafka/pull/13837#issuecomment-1627469910 @showuon @divijvaidya Addressed your review comments. Please take another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #13837: KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager
kamalcph commented on PR #13837: URL: https://github.com/apache/kafka/pull/13837#issuecomment-1618912858 > Did a first round. Will continue in upcoming days. > > It would be very useful if this PR can add at least one test utilizing this setup. Thanks, @divijvaidya and @showuon for reviewing the PR! Addressed your review comments. PTAL. I'll open a separate PR to add the `TieredStorageTestHarness` classes to effectively write an integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #13837: KAFKA-9564: Local Tiered Storage implementation for Remote Storage Manager
kamalcph commented on PR #13837: URL: https://github.com/apache/kafka/pull/13837#issuecomment-1604056026 @satishd Can you please take a look when you get chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
