[GitHub] [kafka] kirktrue commented on pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox


kirktrue commented on pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#issuecomment-949090564


   @junrao - I believe I've addressed all of the points listed except:
   
   1. The listener/SASL mechanism prefix issues are really confusing to me 
because the code is currently behaving the way that I'm assuming it's supposed 
to. For example, if I have a listener named `foo` and an OAuth configuration 
named `bar`, `sasl.oauthbearer.bar=1` is picked up by my code unless there's a 
listener-specific override (e.g. 
`listener.name.foo.oauthbearer.sasl.oauthbearer.bar=2`). And if I specify a 
value for some other listener (e.g. 
`listener.name.someotherlistener.oauthbearer.sasl.oauthbearer.bar=3`, I don't 
see that value in the callback handler that is initialized for the `foo` 
listener.
   2. I need to implement exponential backoff for the case of on-demand refresh 
of the JWKS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kirktrue commented on pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-19 Thread GitBox


kirktrue commented on pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#issuecomment-947122444


   Thanks for the feedback, @YiDing-Duke!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org