[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-16 Thread GitBox


kkonstantine commented on pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#issuecomment-674644885


   Thanks @rhauch ! 
   Tested manually with transforms from the `plugin.path` as well. Merging on 
`trunk` and backporting to `2.6`.  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-13 Thread GitBox


kkonstantine commented on pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#issuecomment-673664418


   Thanks for the comments @rhauch !
   The PR should be ready for another pass. Jenkins still has a long queue of 
jobs. Yesterday 2/3 builds were green. I'm expecting the new job to eventually 
run today too (Builds locally). 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox


kkonstantine commented on pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#issuecomment-673136551


   According to https://status.apache.org the jenkins queue has grown too much 
and the infra team is investigating how to resolve the issues. Thus, the tests 
haven't run yet.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox


kkonstantine commented on pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#issuecomment-673067506


   cc @rhauch @wicknicks 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

2020-08-12 Thread GitBox


kkonstantine commented on pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#issuecomment-673065882


   I'll be adding a few more tests. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org