[GitHub] [kafka] levzem commented on pull request #10299: KAFKA-10070: parameterize Connect unit tests to remove code duplication

2021-03-11 Thread GitBox 


levzem commented on pull request #10299:
URL: https://github.com/apache/kafka/pull/10299#issuecomment-796909792


   @C0urante @kkonstantine @rhauch would appreciate some 👀 , thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] levzem commented on pull request #10299: KAFKA-10070: parameterize Connect unit tests to remove code duplication

2021-03-12 Thread GitBox 


levzem commented on pull request #10299:
URL: https://github.com/apache/kafka/pull/10299#issuecomment-797816232


   tests failing are unrelated to the changes
   
   `Build / JDK 11 / 
kafka.api.PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup()`
   `Build / JDK 15 / 
org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining`
   
   @mimaison thanks for the review, mind taking another pass?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org