[GitHub] [kafka] littlehorse-eng commented on pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

2023-02-13 Thread via GitHub


littlehorse-eng commented on PR #13082:
URL: https://github.com/apache/kafka/pull/13082#issuecomment-1428380050

   Apologies for the delay, @mjsax I've addressed the PR comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] littlehorse-eng commented on pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

2023-02-09 Thread via GitHub


littlehorse-eng commented on PR #13082:
URL: https://github.com/apache/kafka/pull/13082#issuecomment-1424221038

   Thank you very much for the assist here! This looks how I was hoping it
   would look…not bad for a backend engineer 
   
   Now we just need to have someone confirm the actual change (that the second
   paragraph is factually correct—it matched my empirical observations and my
   reading of the code, but there is a nonzero chance I missed something).
   
   On Thu, Feb 9, 2023 at 12:29 AM Lucas Brutschy ***@***.***>
   wrote:
   
   > hmmm, not sure what went wrong there.
   >
   > anyways, this is how it renders:
   >
   > [image: Screenshot 2023-02-09 at 09 28 15]
   > 

   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   -- 
   Colt McNealy
   *Founder, LittleHorse.io*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [kafka] littlehorse-eng commented on pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

2023-02-08 Thread via GitHub


littlehorse-eng commented on PR #13082:
URL: https://github.com/apache/kafka/pull/13082#issuecomment-1422802097

   @lucasbru I used the repo you sent; the home page loaded albeit without CSS 
and when I clicked on Streams documentation it yielded the same result as 
navigating to the file on my localhost. Must be doing something wrong...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org